composer icon indicating copy to clipboard operation
composer copied to clipboard

PyTorch Lightning integration collaboration

Open williamFalcon opened this issue 3 years ago • 3 comments

Love the tricks introduced by mosaic!

We created an issue to enable the broader pytorch community access to these tricks if they want to enable the mosaic optimizations.

Excited to collaborate with you guys to make sure it's done correctly and future proof so that you can continue adding new features without code changes on the Lightning side.

https://github.com/PyTorchLightning/pytorch-lightning/issues/12360

williamFalcon avatar Mar 17 '22 16:03 williamFalcon

Sounds good, looking forward to collaborate! We care most about delivering efficiency methods to the community in whichever form they would like to consume.

hanlint avatar Mar 18 '22 12:03 hanlint

Hello, @williamFalcon and @hanlint.

Do you have any news about this feature?

I am using pytorch lightning, but I think it would be useful to add mosaic training strategies like those proposed in https://github.com/Lightning-AI/lightning/issues/12360. Is there a way to combine both trainers easily?

Thanks for the effort in developing awesome libraries.

heitorrapela avatar Jun 25 '22 16:06 heitorrapela

Yeah, what's happened to this work? Seemed really exciting, then sort of disappeared again.

GeorgePearse avatar Sep 08 '22 09:09 GeorgePearse

Closing since we're not actively planning on integrating speedup methods with lightning. We're happy to discuss and accept / review community PRs though!

mvpatel2000 avatar Jun 22 '23 21:06 mvpatel2000