composer icon indicating copy to clipboard operation
composer copied to clipboard

Correctly process `parallelism_config['tp']` when it's a dict

Open snarayan21 opened this issue 1 year ago • 5 comments

What does this PR do?

This fixes a bug where if the TP configuration (specified through parallelism_config['tp']) was passed in as a dict, it would not be correctly processed into the final parallelism_config. This also means that whenever we were specifying the TP config as a dict before, it was not actually being set.

Modified unit tests to make sure the TP config is actually being set.

What issue(s) does this change relate to?

Before submitting

  • [ ] Have you read the contributor guidelines?
  • [ ] Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • [ ] Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • [ ] Did you update any related docs and document your change?
  • [ ] Did you update any related tests and add any new tests related to your change? (see testing)
  • [ ] Did you run the tests locally to make sure they pass?
  • [ ] Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

snarayan21 avatar Jun 27 '24 19:06 snarayan21

@mvpatel2000 I keep getting errors on 4 gpu tests because it's detecting the FutureWarning and counting that as an error. I've tried filtering out these warnings but that doesn't seem to be working, including adding the warning to the pyproject.toml config for pytest. What's the right way to filter these?

snarayan21 avatar Jun 28 '24 20:06 snarayan21

@mvpatel2000 I keep getting errors on 4 gpu tests because it's detecting the FutureWarning and counting that as an error. I've tried filtering out these warnings but that doesn't seem to be working, including adding the warning to the pyproject.toml config for pytest. What's the right way to filter these?

pytest.mark.filterwarning?

mvpatel2000 avatar Jun 28 '24 20:06 mvpatel2000

@mvpatel2000 I already added this @pytest.mark.filterwarnings('ignore:.*(TP) is experimental.*:FutureWarning') on all relevant tests...

snarayan21 avatar Jun 28 '24 20:06 snarayan21

@mvpatel2000 I already added this @pytest.mark.filterwarnings('ignore:.*(TP) is experimental.*:FutureWarning') on all relevant tests...

I think its a regex issue, should be \(?

mvpatel2000 avatar Jun 28 '24 20:06 mvpatel2000

ah that makes sense @mvpatel2000 lemme try

snarayan21 avatar Jun 28 '24 20:06 snarayan21