composer icon indicating copy to clipboard operation
composer copied to clipboard

remove orig_params check

Open milocress opened this issue 1 year ago • 0 comments

What does this PR do?

Allows load_fsdp_monolith_rank0_only and use_orig_params to both be set to True - this was initially disabled due to a pytorch issue I think, but has since been resolved.

What issue(s) does this change relate to?

Before submitting

  • [x] Have you read the contributor guidelines?
  • [ ] Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • [ ] Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • [ ] Did you update any related docs and document your change?
  • [ ] Did you update any related tests and add any new tests related to your change? (see testing)
  • [ ] Did you run the tests locally to make sure they pass?
  • [x] Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

milocress avatar Feb 08 '24 22:02 milocress