composer icon indicating copy to clipboard operation
composer copied to clipboard

Remove subclasses from composer

Open bmosaicml opened this issue 1 year ago • 0 comments

What does this PR do?

This PR removes/deprecates the ICL(Dataset|Metric) subclasses and migrates the relevant tests. This PR is not strictly necessary but would help prevent confusion about where ICL code actually lives. It's related to this foundry PR: https://github.com/mosaicml/llm-foundry/pull/936

What issue(s) does this change relate to?

Before submitting

  • [ ] Have you read the contributor guidelines?
  • [ ] Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • [ ] Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • [ ] Did you update any related docs and document your change?
  • [ ] Did you update any related tests and add any new tests related to your change? (see testing)
  • [ ] Did you run the tests locally to make sure they pass?
  • [ ] Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

bmosaicml avatar Feb 04 '24 15:02 bmosaicml