composer icon indicating copy to clipboard operation
composer copied to clipboard

CheckpointSaver take Path object along with str

Open ilee300a opened this issue 1 year ago • 1 comments

🚀 Feature Request

Currently CheckpointSaver only takes strings for folder and file names, but it would be nice for it to also take Path objects.

Motivation

Those attributes are ultimately converted to path objects. When creating a child class from the CheckpointSaver, when we call the parent's initializer, we have to cast all of those back to strings

ilee300a avatar Sep 29 '22 23:09 ilee300a

Hi @ilee300a, That is a great idea! We are currently refactoring the CheckpointSaver and will add that to our plan.

eracah avatar Sep 30 '22 01:09 eracah

Hey, @ilee300a, this didn't quite make it into v0.11, but we'll do a hotfix this week and add it!

eracah avatar Oct 25 '22 17:10 eracah