composer icon indicating copy to clipboard operation
composer copied to clipboard

Copy paste

Open BehradToghi opened this issue 2 years ago • 3 comments

Copy Paste augmentation, ready for review.

BehradToghi avatar Aug 04 '22 21:08 BehradToghi

I did not delete the debug_out folder (which contains some sample outputs of CopyPaste, in case you need them in the future. Please feel free to take it out of the PR late. @Landanjs

BehradToghi avatar Aug 04 '22 21:08 BehradToghi

I think the debug folder was committed by mistake?

Going to defer to others for reviews on algorithms...

It's a useful reference to look at while reviewing, but yes we need to remember to remove all of the images before merging

eracah avatar Aug 05 '22 00:08 eracah

I'm not sure if Daya needs to be a reviewer, but I can't remove him? Cory, Evan and I should be enough

Landanjs avatar Aug 05 '22 16:08 Landanjs

It automatically requested a review from you @dblalock 😞

Landanjs avatar Aug 24 '22 23:08 Landanjs

@Landanjs are we still trying to merge this? I keep getting notifications about how this needs review

dblalock avatar Aug 31 '22 19:08 dblalock

I was addressing comments and trying to fix pyright in my own fork at branch landan/copy-paste, but I couldn't finish it in time... So it might be 1.5 weeks until another update. @dblalock could you approve to prevent notifications? Austin, Cory, and Evan would be the main reviewers

Landanjs avatar Aug 31 '22 20:08 Landanjs

Hi all, I was unable to get an improvement from CopyPaste on ADE20k (see wandb runs). I tried a few tweaks and adjusting hyperparameters, but without success. Since semantic segmentation specific speedups have lower priority now and this was designed for instance segmentation (which we don't have), we decided to merge it in the contrib repo so we can come back to the method in the future. Here is the mcontrib PR

Landanjs avatar Sep 20 '22 23:09 Landanjs