composer icon indicating copy to clipboard operation
composer copied to clipboard

Remove `xfail` in `tests/algorithms/algorithm_settings` with a `simple_hf_settings` option

Open jzf2101 opened this issue 2 years ago • 1 comments

🚀 Feature Request

Per @ravi-mosaicml, can we build off of #992 and get rid of some of our xfail errors by adding some algorithm settings using our HF models?

https://github.com/mosaicml/composer/blob/f1862b8ebd4191a0ce6fc54d5a46ad5d0293451e/tests/algorithms/algorithm_settings.py#L192-L193

Motivation

Right now we only have vision-related settings:

https://github.com/mosaicml/composer/blob/f1862b8ebd4191a0ce6fc54d5a46ad5d0293451e/tests/algorithms/algorithm_settings.py#L26-L49

jzf2101 avatar Jun 02 '22 22:06 jzf2101

Yes, we should add canonical settings for NLP for each algorithm!

hanlint avatar Jun 02 '22 22:06 hanlint

Closing. Tracking elsewhere as low pri. We're open to community suggestions!

mvpatel2000 avatar Jun 22 '23 21:06 mvpatel2000