bootstrap-rtl icon indicating copy to clipboard operation
bootstrap-rtl copied to clipboard

might not need to keep a "cdnjs" folder

Open Amomo opened this issue 10 years ago • 5 comments

Hi @morteza , I have made a PR to add the latest bootstrap-rtl in cdnjs. my PR : https://github.com/cdnjs/cdnjs/pull/5295

And, I add a auto-update config in package.json for cdnjs. That will let cdnjs automatically add the latest version by the git tags.

I think you might not need to keep a cdnjs folder in dist/. cdnjs would host these version for you.

Thank you!

Amomo avatar Aug 29 '15 06:08 Amomo

We should first figure out what's the difference between the cdnjs inside and outside. It didn't been updated for a while.

PeterDaveHello avatar Aug 29 '15 12:08 PeterDaveHello

@Amomo @PeterDaveHello Thank you guys. It's still referring to 3.2.x. What is up on updating cdnjs and your PRs?

morteza avatar Oct 02 '15 05:10 morteza

I wonder if we should grab files directly from dist/css and dist/js or from dist/cdnjs? Seems it's old, is there any special in cdnjs folder? Thanks.

PeterDaveHello avatar Oct 09 '15 11:10 PeterDaveHello

The updated ones are all inside dist/ directory. That cdnjs/directory is kinda old, used to push changes to the cdnjs repo, and must be removed now.

morteza avatar Oct 09 '15 15:10 morteza

Okay, let's remove it :+1:

PeterDaveHello avatar Oct 09 '15 15:10 PeterDaveHello