Morten Piibeleht

Results 540 comments of Morten Piibeleht

> That's not going to happen in the foreseeable future (i.e. pre-Julia 2.0), because it's used _by default_ for docstrings That's why we can't _remove_ it pre-2.0. But we can...

@DilumAluthge Buildkite is not yet deploying the PDF though, right? Or did I miss something?

This is the function that handle the actual push to the `assets` branch: https://github.com/JuliaLang/docs.julialang.org/blob/16a515e71f2ea6bb2b18a68eb510ab453db35f32/pdf/make.jl#L140-L190 Basically, add/update the PDFs to the branch, and then `commit --amend` and force push. We squash...

Sorry for the delay. But if I'm not mistaken, Documenter already sets the name, and we just copy any PDF there is: https://github.com/JuliaDocs/Documenter.jl/blob/998d26e568a20e3b1764d0c2cef30ebe4d2563ae/src/Writers/LaTeXWriter.jl#L167-L174

Oh, sorry, you are right. The renaming logic works by passing this https://github.com/JuliaLang/docs.julialang.org/blob/16a515e71f2ea6bb2b18a68eb510ab453db35f32/pdf/make.jl#L74 which has the version number, to this https://github.com/JuliaLang/docs.julialang.org/blob/16a515e71f2ea6bb2b18a68eb510ab453db35f32/pdf/make.jl#L58-L69 where we look for any PDF and rename it...

I almost certainly won't have the bandwidth for it. But if someone does want to embark on this, then I'd just say that the Documenter SCSS files should refactored anyway,...

It came up here: https://github.com/SciML/OrdinaryDiffEq.jl/pull/1866

In reference to https://github.com/SciML/OrdinaryDiffEq.jl/pull/1866#discussion_r1112785431, I don't think an `@template` would be sufficient for that use case. I would assume that, in general, you might have different templates for different _groups_...

> Custom `@doc` seems to me to be a bit much. I don't think it's machinery that package authors should be overridden in that way. Yeah, agreed, this feels a...

That's a fair point. Maybe it should filter by module somehow?