mortelli

Results 27 comments of mortelli

or, alternatively—depending on how the acceptance criteria is interpreted—the user **only** specifies the BZZ network ID, and the blockchain ID is determined based on that, i.e. the user does not...

> And, I would create a hard-coded mapping (compile-time), but IMO, there is not a very big difference between the two in this implementation. ### hard-coded alternative #### pros a...

> A Swarm never trigger a `ChequeBounced` event on the chequebook smart-contract side. What do you mean by this? > Currently, a node will happily boot up and allow you...

> If the chequebook is presented a cheque which he cannot pay out (insufficient liquid balance), a `ChequeBounced` event is emitted. In the current implementation, this does not have any...

Adding the `help needed` tag in an attempt to solve current issues and move ahead with development.

> i'm not convinced with the idea of using RPCs internally, i.e. for "regular" SWAP logic. i'd prefer (at least) wrapper functions for RPCs which are not used anywhere else....

> due to new deadlock, peer lock calls in the `Cheques` function had to be (temporarily) commented out. > > `Add` activates a peer lock when called, and once `AvailableBalance`...

> @mortelli , what is the status here? still in progress, but not actively being worked on right now

even though i still have to add a test for this, i am going to preliminary request reviews from @Eknir and @santicomp2014 as well

possible cause elucidated [here](https://github.com/ethersphere/swarm/pull/1983#discussion_r369555597)