Ripes icon indicating copy to clipboard operation
Ripes copied to clipboard

Retina Support on Mac Request

Open ZhaoZuohong opened this issue 3 years ago • 6 comments

Ripes does not support Retina display.

image

ZhaoZuohong avatar Apr 05 '21 22:04 ZhaoZuohong

Hi @ZhaoZuohong Sorry for the delay. Is the issue that the icons in the toolbar are rendered too large?

mortbopet avatar Apr 22 '21 07:04 mortbopet

No, the size of the icons are correct, but the whole interface is fuzzy, and ppi is low.

ZhaoZuohong avatar May 06 '21 11:05 ZhaoZuohong

Marking this as help wanted since I don't have access to a retina display, so it's a bit tricky for me to work on/verify a solution.

mortbopet avatar Oct 18 '21 13:10 mortbopet

So far, I have not run into any major issues by forcibly enabling retina support in Contents/info.plist by adding

<key>NSHighResolutionCapable</key>
<true/>

The images could be of higher resolution, but most of the interface itself scales well. However, the text editor does appear to have a small font size, but I think that's a more general issue.

taesungh avatar Oct 23 '21 23:10 taesungh

I see; sounds like we need to come up with a script to run during the bundling step in CI: https://github.com/mortbopet/Ripes/blob/0ff4b909a142961f06c5ad891288b280761e799a/.github/workflows/mac-release.yml#L50-L57

which can add the given key. Looking into it, we might aswell also look at adding a bundle icon as well.

The images could be of higher resolution

This is also something to look into; all of the icons in Ripes are svg files, so i had hoped that the internals of Qt would be smart enough to render the icons at an appropriate size, but looks like this isn't the case per default...

mortbopet avatar Oct 24 '21 09:10 mortbopet

Added NSHighResolutionCapable as well as what i hope to be support for a bundle icon in 4069b762adf4b808382296c76e7305615bfa450b and f21d5fc2632d0aabf9b4c7922787a2b4e6e16dac. @taesungh please let me know if these things seem to be working (can be checked through the continuous build).

mortbopet avatar Oct 24 '21 14:10 mortbopet