(solved) Module not compiling with k5.17-rc1

[petehg]

I can sometimes work these out and create a patch myself if it's straightforward. This one I dont understand. Have you tested? Is there a patch on the way? Here's what I get: /var/lib/dkms/8812au/1.0/build/os_dep/osdep_service.c: In function ‘thread_exit’: /var/lib/dkms/8812au/1.0/build/os_dep/osdep_service.c:1312:9: error: implicit declaration of function ‘complete_and_exit’ [-Werror=implicit-function-declaration] 1312 | complete_and_exit(comp, 0); | ^~~~~~~~~~~~~~~~~ /var/lib/dkms/8812au/1.0/build/os_dep/linux/os_intfs.c: In function ‘rtw_net_set_mac_address’: /var/lib/dkms/8812au/1.0/build/os_dep/linux/os_intfs.c:1624:28: warning: passing argument 1 of ‘_rtw_memcpy’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] 1624 | _rtw_memcpy(pnetdev->dev_addr, sa->sa_data, ETH_ALEN); /* set mac addr to net_device */ | ~~~~~~~^~~~~~~~~~ In file included from /var/lib/dkms/8812au/1.0/build/include/drv_types.h:27, from /var/lib/dkms/8812au/1.0/build/os_dep/linux/os_intfs.c:17: /var/lib/dkms/8812au/1.0/build/include/osdep_service.h:313:35: note: expected ‘void *’ but argument is of type ‘const unsigned char *’ 313 | extern void _rtw_memcpy(void *dec, const void *sour, u32 sz); | ~~~~~~^~~ /var/lib/dkms/8812au/1.0/build/os_dep/linux/os_intfs.c: In function ‘rtw_os_ndev_register’: /var/lib/dkms/8812au/1.0/build/os_dep/linux/os_intfs.c:2160:25: warning: passing argument 1 of ‘_rtw_memcpy’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] 2160 | _rtw_memcpy(ndev->dev_addr, adapter_mac_addr(adapter), ETH_ALEN); | ~~~~^~~~~~~~~~ In file included from /var/lib/dkms/8812au/1.0/build/include/drv_types.h:27, from /var/lib/dkms/8812au/1.0/build/os_dep/linux/os_intfs.c:17: /var/lib/dkms/8812au/1.0/build/include/osdep_service.h:313:35: note: expected ‘void *’ but argument is of type ‘const unsigned char *’ 313 | extern void _rtw_memcpy(void *dec, const void *sour, u32 sz); | ~~~~~~^~~ CC [M] /var/lib/dkms/8812au/1.0/build/os_dep/linux/rtw_android.o cc1: some warnings being treated as errors make[2]: *** [/usr/src/linux-5.17.0-rc1-2.g8751a94/scripts/Makefile.build:289: /var/lib/dkms/8812au/1.0/build/os_dep/osdep_service.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [../../../linux-5.17.0-rc1-2.g8751a94/Makefile:1845: /var/lib/dkms/8812au/1.0/build] Error 2 make[1]: Leaving directory '/usr/src/linux-5.17.0-rc1-2.g8751a94-obj/x86_64/default' make: *** [Makefile:2486: modules] Error 2

[morrownr]

Hi @petehg

I was looking for you. I'm too busy to load and test k5.17 right now so I need someone to handle it. I have now merged the k5.17 support so if you would be so kind as to follow the driver removal instructions and re-accomplish the installation instructions, I would appreciate it. Please provide a report.

Regards

[petehg]

Compiled successfully with dkms. No error messages. Thanks very much for being so prompt. I can't find any logs which is usual when it's successful but if there's something more you'd like to see just tell me where to look.

[morrownr]

Hi @petehg

Compiled successfully with dkms. No error messages.

That is all I need. Thanks for taking the time to test the 5.17 support.

Regards