Christopher J. Morrone

For the test_* binaries that come from ovis_util, perhaps those could simply change from being installed bin_PROGRAMS to being "make check" check_PROGRAMS?

Does anyone have an opinion on what to do with libcoll and libmmalloc? My initial impression is that they look like internal support libraries rather than something that should be...

Ah, a simpler way to fix this is probably to just not store the set in the base_data_t, and instead pass it to base_* functions as needed. The data in...

Bug that I'll fix along the way: sampler_base calls ldms_set_publish, but doesn't ever call ldms_set_unpublish().

@tom95858 , is all of that code on master? Looking at master, I do see a number of things to really like about that code. Some of the headers seem...

> dlsym() is not particularly zippy and calling it six gazillion times is certainly sub-optimal. Ok, well cache the symbol address ... where ... in a struct! We could certainly...

No, I do understand that. But I'm saying it isn't terribly good practice to do that. That practice is not clear or explicit to the reader of the code. A...

@tom95858 , I rather suspect that the way that this extends structs, in your biffle example, is not C standards compliant. Doing this is C standards compliant: ``` struct biffle...

> Hi @morrone, > > Perhaps I missing your point, but this is not non-standard C. This model is used extensively all over the Linux kernel and throughout LDMS. The...

I suspect that something was lost in translation, because I don't think we want that in the TOSS packages. Is there anything else in TOSS that works this way? Tools...