Ardent icon indicating copy to clipboard operation
Ardent copied to clipboard

Should Ardent have a TypeException?

Open Wes0617 opened this issue 9 years ago • 2 comments

I would throw an EngineException (PHP7) for consistency with PHP's own type hinting. Or, better, I'd use trigger_error() for PHP5 compatibility (which would presumably result in a EngineException in PHP7)

Wes0617 avatar Apr 02 '15 22:04 Wes0617

PHP 7 is likely adding a TypeException class. I'll wait to see how that all pans out.

morrisonlevi avatar Apr 08 '15 14:04 morrisonlevi

As an update PHP 7 will have TypeError which does not descend from \Exception but is a sibling class instead. I will need to re-evaluate what I do in this repository for all exceptions because of this.

morrisonlevi avatar Sep 14 '15 02:09 morrisonlevi