FileContextCore icon indicating copy to clipboard operation
FileContextCore copied to clipboard

We need the package to support.NET 5.0!!!

Open SundayRX opened this issue 4 years ago • 5 comments

SundayRX avatar Jan 10 '21 02:01 SundayRX

Hi.

Yes that's a good point. I'm currently pretty busy but will update the library soon.

Best regards

Morris

morrisjdev avatar Jan 10 '21 14:01 morrisjdev

Thank you very much for your hard work after work. I will always pay attention to the progress of the project

SundayRX avatar Jan 17 '21 02:01 SundayRX

Do you have an estimate when it could be done? Not to be disrepectfull, but I'm just curious :).

Koenman5534 avatar Mar 10 '21 15:03 Koenman5534

It appears that FileContextTransactionManager class is missing CommitTransactionAsync method, so is it possible to just add the following? Of course there may be additional changes to upgrade the provider to .NET 5.0 but possibly not.

public virtual Task CommitTransactionAsync(CancellationToken cancellationToken = default)
{
    _logger.TransactionIgnoredWarning();
    return Task.CompletedTask;
}

mguinness avatar Oct 14 '21 01:10 mguinness

Looking into this further there is a lot of work required to update the library. There is an open issue Improve documentation on how to write an EF Core provider that could aid this effort.

mguinness avatar Nov 12 '21 17:11 mguinness