vinyl-ftp icon indicating copy to clipboard operation
vinyl-ftp copied to clipboard

Suggested fix for #97, review of implications required

Open nilsvu opened this issue 7 years ago • 1 comments

With the prepended slash, minimatch will never actually return an object with negate: true, so it's impossible to ignore files in clean operations. Please review this change and consider implications to the remaining codebase - perhaps even consider refactoring to use the glob processing implementation in vinyl-fs, that also gulp.src uses, if possible?

Fixes #97

nilsvu avatar Jan 17 '18 01:01 nilsvu

This looks like it could break a lot of scripts relying on the current behavior. Could you update this to still prepend the slash but somehow parse the negation beforehand? Ideally with a test? Many thanks!

morris avatar Jan 27 '18 13:01 morris