bazarr icon indicating copy to clipboard operation
bazarr copied to clipboard

no log: Replace raw html bold tag inside text with Mantine Text

Open anderson-oki opened this issue 5 months ago • 0 comments

Description

Refactor the nested raw <b> tag inside of the Message component in favor to protect the Separation of Concerns.

A couple reasons to apply the change:

  1. Consistency with Design System:

When using the raw HTML tag we need to style it by ourselves, if the Design System changes, it won't cascade the change to the components automatically.

  1. Semantic Meaning

Mantine Text component can be changed to simply style of give more accessibility by changing <b> to <strong> at any point, since <b> is simply visual.

  1. Easy Customization

We can add more styling as needed such as color, italic, by simply passing the properties to the component that exists instead of manually nesting and styling ourselves.

anderson-oki avatar Aug 28 '24 00:08 anderson-oki