bazarr
bazarr copied to clipboard
morpheus65535
fix_uppercase should run after remove_HI is finished
Describe the bug Not exactly sure if it's a 'bug' and if this is only very specific for the subtitles I have (extracted using the "Embedded Subtitles" provider. The subtitles look like this:
9
00:00:41,417 --> 00:00:43,127
OW!
10
00:00:43,127 --> 00:00:44,754
BACK UP!
11
00:00:44,754 --> 00:00:47,590
COMING OUT!
12
00:01:02,271 --> 00:01:05,566
(Slim Smith & the Uniques'
"My Conversation" playing)
Everything apart from the HI is uppercase. So if I manually first 'remove HI' and then 'Fix uppercase' then it works correctly.
However because 'only_uppercase' is determined before 'remove HI' is run (when enabling the different post processing steps to run automatically), the variables self.only_uppercase (https://github.com/morpheus65535/bazarr/blob/master/libs/subzero/modification/main.py#L213) is set to false.
Then the fix_uppercase modification will be skipped completely.
To Reproduce Take any subtitles that are all uppercase, except for the HI texts. If enabling the post processing to remove HI and fix uppercase, only the HI will be removed.
Expected behavior When manually first removing HI and then fixing uppercase it works.
Software (please complete the following information):
- Bazarr: [v 1.1.0]
- Linux Ubuntu 20.04
Additional context
I guess 'only_uppercase' should be checked after 'remove_HI' has been run. I wonder if checking if everything is uppercase or not makes more sense within the modify function of the FixUppercase class?
[EDIT]: just realized that actually the issue is the HI element spanning over two lines. It looks like:
FullBracketEntryProcessor (which is run from here: https://github.com/morpheus65535/bazarr/blob/master/libs/subzero/modification/main.py#L190)
should be executed on the entire 'entry' instead of on every single line separately.
I tried moving detect_uppercase() into FixUppercase and it works, I can prepare a PR for that if that is desired.
Thanks for reporting this issue. Yes I would appreciate if you could create a PR to dev branch for that one. Thanks!
ok will do, but will take some time until I can clean it up.
No problem, thanks for that!
Had this laying around for ages, finally submitted. Thanks for the ping.