morph166955
morph166955
@clinique I hit most of the fast low hanging fruit changes. The rest need a little more time than I have right now, I'll hit those later today or this...
@clinique I'm at an impasse after looking at the comments about a dedicated configuration class. It looks like the original author was using the thing configuration to store some persistent...
EDIT: Found a cleaner way to do this.
Ok, I think I found a nice middle ground with the configuration. It's compiling cleanly, I haven't done a regression test on it yet. Let me know what you think...
EDIT: Resolved in [2d267b1](https://github.com/openhab/openhab-addons/pull/14600/commits/2d267b1a23817e3690de7649e1897bf0f7a5386d) User reported exception being thrown: ``` 2023-03-31 15:36:28.522 [ERROR] [core.thing.internal.ThingManagerImpl] - The ThingHandler caused an exception while handling the removal of its thing java.lang.IllegalArgumentException: Illegal status...
Found exception during debuging: ``` 2023-04-03 17:10:34.074 [DEBUG] [ing.ring.handler.AbstractRingHandler] - Exception occurred during execution of startAutomaticRefresh(): Cannot invoke "String.length()" because "s" is null java.lang.NullPointerException: Cannot invoke "String.length()" because "s" is...
There are a few small things I'm waiting to hear testing results on from the marketplace, but this is more or less ready for a review at this time.
> There are a few small things I'm waiting to hear testing results on from the marketplace, but this is more or less ready for a review at this time....
@openhab/add-ons-maintainers This is ready for a first pass review. I realize there are a TON of SAT issues. I have a feeling that there will be some significant changes as...
This is updated for 4.1.0