shallow-equal icon indicating copy to clipboard operation
shallow-equal copied to clipboard

TS migration

Open ndelangen opened this issue 5 years ago • 2 comments

fixes: https://github.com/moroshko/shallow-equal/issues/13

migrated the codebase to typescript & overhauled the build tools to use pika

ndelangen avatar Dec 13 '19 15:12 ndelangen

#7 actually already done. We forgot to close the issue.

TrySound avatar Dec 13 '19 22:12 TrySound

WDYT, could this be released as a new major?

ndelangen avatar Dec 16 '19 09:12 ndelangen

@ndelangen : thank you for all your work on this. I've forked the codebase, integrated your changes, updated the release mechanism and bundler, added tests as well as a generic shallowEqual, and have launched it as shallow-equal-modern.

Update: I've deprecated shallow-equal-modern now that this package supports Typescript.

fivecar avatar Jan 11 '23 01:01 fivecar

I'm sorry guys. I really struggle with time. If anyone in interested to continue maintaining this package, please react out on Twitter.

moroshko avatar Jan 11 '23 08:01 moroshko

I don't think any code in storybook uses this, sorry, I'll close this PR to reduce noise.

ndelangen avatar Jan 11 '23 13:01 ndelangen

v3.0.0 of this package now supports Typescript. Thanks, @ndelangen, for starting us down this path. (Also now uses microbundle, FWIW).

fivecar avatar Jan 26 '23 02:01 fivecar