react-autowhatever icon indicating copy to clipboard operation
react-autowhatever copied to clipboard

Remove dependency on react-themeable

Open bbenezech opened this issue 8 years ago • 4 comments

It's a 10ish lines lib that relies on an outdated version of object-assign (3.0.0 when everyone has moved on to 4.1.0). It looks unmaintained :(

It smells funny on the otherwise clean react-autosuggest dependency tree.

I'd say either inline its code or remove the functionality, it looks like the idea hasn't caught on :(

bbenezech avatar Jan 13 '17 10:01 bbenezech

@markdalgleish Any plans to continue maintaining react-themeable?

it looks like the idea hasn't caught on

@bbenezech Do you mean the whole idea of allowing people to style react-autosuggest using their preferred styling solution?

or remove the functionality

Does it mean we force everyone to use inline styles (or something else)?

I'd love to hear more thoughts on this topic.

moroshko avatar Jan 14 '17 07:01 moroshko

@moroshko is there something you feel is missing from react-themeable for your purposes?

markdalgleish avatar Jan 14 '17 07:01 markdalgleish

@markdalgleish https://github.com/markdalgleish/react-themeable/issues/8

moroshko avatar Feb 19 '17 07:02 moroshko

@moroshko 2.5y without changes to react-themeable I believe it's safe to declare this as unmaintained. We use the theme functionality and it's great but resent the old object-assign dependency which duplicates this package. Would love to see this lib move away from this dependency and only if to not seem as unmaintained as it might seem now. Inlining this lib code would at least give an opening for nested keys support PR should anyone from the community want that enough.

yoadsn avatar Jan 12 '19 17:01 yoadsn