react-autosuggest icon indicating copy to clipboard operation
react-autosuggest copied to clipboard

Remove unexpected listbox role from autowhatever items container. Fix #701

Open thibaudcolas opened this issue 2 years ago • 4 comments

This fixes #701. Currently this can be done per-project with renderSuggestionsContainer, but there is no reason for this container to have a listbox role to start with since the list within already does.

Once this is fixed, I believe #770 will be the only bug preventing this project from really following WAI-ARIA combobox markup to the letter.

thibaudcolas avatar Oct 12 '21 23:10 thibaudcolas

Hello, is there any chance that this is still going to be merged given the almost one year anniversary of this PR @pimterry? :pray:

danielbick avatar Oct 12 '22 10:10 danielbick

I only briefly helped with maintenance a while back, when there was a particular backlog, I'm not actively maintaining this project. I'm afraid I don't have time to look into this change and confirm whether it's correct or whether it has other consequences.

As noted at the top of the README this project is looking for maintainers! If you or anybody else wants to take it on, send a message to moroshko on Twitter.

pimterry avatar Oct 12 '22 10:10 pimterry

This and #770 are vital for fixing some accessibility issues and some other unexpected behaviours.

I have reached out to moroshko on twitter to see if there’s a way we can merge a couple of these important PRs without agreeing to take over the project. I’m happy to help but not super capable. @thibaudcolas would you also be available to help?

david-buck avatar Jan 22 '23 22:01 david-buck

@david-buck yeah I can certainly help land those two pull requests, and perhaps a few other ones, if we’re able to do so. The project tooling is pretty similar to other ones I’ve worked on so it should be no problem. Looks like the only access needed would be to the GitHub repository to create releases there for the release notes like past releases, and then npm to publish the package.

thibaudcolas avatar Jan 26 '23 20:01 thibaudcolas