react-autosuggest icon indicating copy to clipboard operation
react-autosuggest copied to clipboard

role="listbox" both on suggestionsContainer as well as suggestion ul

Open gaurav5430 opened this issue 4 years ago • 3 comments

Codepen: https://codepen.io/gaurav5430/pen/rNaYgBe?editors=0010

  1. Focus on the input field
  2. Type c, and wait for suggestions to appear
  3. Look at the rendered html

Observed behaviour: both the suggestions container and the suggestions ul have role="listbox"

Expected behaviour: only the ul should have role="listbox".

Screenshot 2020-01-04 at 11 26 26 PM

gaurav5430 avatar Jan 04 '20 17:01 gaurav5430

I think this is a regression, it seems to not set the role="listbox" on the container in 9.0.0 , but it does so in the latest version which is 9.4.3

gaurav5430 avatar Jan 04 '20 18:01 gaurav5430

This issue seems to persist from v9 into v10.

sundquistm avatar May 12 '21 01:05 sundquistm

This seems like a pretty straightforward fix for an issue affecting all users of the library, so I gave it a shot in #830.

thibaudcolas avatar Oct 13 '21 00:10 thibaudcolas