Misha Moroshko

Results 66 comments of Misha Moroshko

Is setting and removing attributes the only thing we do with the `appElement`? If so, what if we had a PropTypes function that checked whether `appElement` has a `setAttribute` (and...

Do you mean `PropTypes.node`? It doesn't feel right, since it can be a number, for example.

How could I try this branch in my app? It doesn't contain the `lib` folder which `main` in `package.json` points to. I get: > Can't resolve 'react-modal' Could you publish...

@diasbruno Any chance to publish this fix to npm (even as a beta version)?

@diasbruno I'm afraid it's not easy to test it the way you propose. I'm getting various errors like: ``` SyntaxError: Unexpected token ``` and ``` Support for the experimental syntax...

The original warning has gone, but now we get: > Warning: Invalid argument supplied to oneOfType. Expected an array of check functions, but received an object at index 0.

@diasbruno Any thoughts how to proceed from here?

@diasbruno What do you think about adding the `window` prop? Do you have other ideas?

I'm sorry guys. I really struggle with time. If anyone in interested to continue maintaining this package, [please react out on Twitter](https://twitter.com/moroshko).