Run SwiftLint on changed code when a PR is created
Checklist
- [x] I have described what this PR contains
Choose one of the following two options:
-
- [x] This PR does not introduce major changes
-
- [ ] This PR introduces major changes, and I have consulted the Mlem Development Matrix room
Choose one of the following two options:
-
- [x] This PR does not change the UI in any way
-
- [ ] This PR adds new UI elements / changes the UI, and I have attached pictures or videos of the new / changed UI elements
Pull Request Information
About this Pull Request
Run SwiftLint on changed code when a PR is created using GitHub Actions workflow file
Screenshots and Videos
If any code fails linting, the warnings and errors will be published to an HTML report that is attached to the Action run as an Artifact:
Additional Context
@mormaer Yeah, that's fair. I'm not running on a Mac, so I can't help with that, unfortunately. Feel free to close this PR if you want
I think this addressed with #304 , but because we don't have CI builds set up it might still be nice to run this as a first step.
We can't always rely on people running/building the code they push :)
I think this addressed with #304 , but because we don't have CI builds set up it might still be nice to run this as a first step.
We can't always rely on people running/building the code they push :)
I was going to suggest we hold this PR and raise an issue referencing it, as when we get the repo moved to a proper account and start running CI on it this should be included for sure
Closing, implemented in #351