Morlay

Results 93 comments of Morlay

It could be work well with custom wrapper ```dart class ListWrap { List list factory ListWrap.fromJson(List json) => _$ListWrapToJson({"list": json}); List toJson() => _$ListWrapToJson(this)["list"] } ``` But will not work...

I wrote another tool for this too. https://morlay.github.io/genshin-level-up/?uid=194435467 Sorry for just Chinese version. I don't know how to fetch user data from hoyolab api. Source code https://github.com/morlay/genshin-level-up

waiting for https://github.com/docker/buildx/issues/893 using host network in k8s is an anti-pattern.

When using babel-transform-react-jsx with `runtime: automatic`, and set `@jsxImportSource` to switch custom `jsx-runtime` But if the fallback exists. codes transformed like below. ```jsx // @jsxImportSource @emotion/core // convert to import...

@gaearon My concern is why we need do the fallback. if we just want to pass key prop, i think `` => `jsx("span", {...obj, key}, key)` could got same result...

@Andarist There is a point i confused - "only key after props spread do the fallback" ```jsx /** @jsxImportSource @emotion/react */ ; ; // will convert to import { createElement...

> I think the `createElement` case is part of the reason, as we need to keep supporting `` but the new JSX signature needs `key` as a separate argument. How...

By infomation from https://github.com/reactjs/rfcs/blob/createlement-rfc/text/0000-create-element-changes.md#deprecate-spreading-key-from-objects i think the transforming rules could be unified: * `` => `jsx("div", stuffWithKeyProp)` * if key needed, warning `key` missing * `` => `jsx("div", stuff, "key-before")`...

@ljharb you mean confusing for the current transforming results or my suggestion?

> The tricky case is when you have and you don't know whether there's a key in there. Because static analysis can't catch that. That's the most important one we'll...