Fix search with a dropdown and with a booleanfield

[etiennepouliot]

trafficstars

Does not make sense to use __icontains by default when we have a drop box :

Make more sense

Also fix searching a BooleanField :

Same without a dropbox :

[morlandi]

Thank you @etiennepouliot Could you please check my question about changes in filter.py ?

[etiennepouliot]

@morlandi where is your question ?

[morlandi]

@etiennepouliot I'm not very familiar with github code review tools ... I can see my question right a few lines above this message, and suppose (but I'm not sure) you should see it as well:

or, go to the "File changes" tab of this PR, then scroll down until you see my question just below the pertinent code; here is where I posted it, and you can probably post a reply too:

[etiennepouliot]

Not sure why, but I can't see your comment.

But no, what I'm really testing is if we have one the letter of 'yes' in the filter so that we can filter for True.

IE , if the user partially type 'ye' if will filter for True, wich is intuitive for the user.

[morlandi]

I see ... mumble mumble ... just wondering: If I type any letter, say "x", nothing is selected, but then if I remove pressing backspace, thus receiving an empty string, then only the True records would be selected, filtering out the False ones ?

[etiennepouliot]

You're right, nice catch.

Should be better with the last commit