Windows Build issue

[sandeeptt]

Hi

I compiled sources from master branch on Windows with VS2013 and get few build/linking errors for the SHARED library output. With some modifications, I could fix those errors. Where can I submit the patch?

[sandeeptt]

Patch attached:

diff --git a/CMakeLists.txt b/CMakeLists.txt index 0abf076..fa7bb6b 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -23,7 +23,6 @@ MBFL_CHECK_INCLUDE("memory.h") MBFL_CHECK_INCLUDE("strings.h") MBFL_CHECK_INCLUDE("string.h")

CHECK_FUNCTION_EXISTS("strcasecmp" HAVE_STRCASECMP) CHECK_FUNCTION_EXISTS("strchr" HAVE_STRCHR)

@@ -31,6 +30,14 @@ configure_file(${CMAKE_CURRENT_SOURCE_DIR}/config.h.cmake ${CMAKE_CURRENT_SOURCE

add_definitions(-DHAVE_CONFIG_H=1)

+IF (WIN32)

• add_definitions(-DMBFL_DLL_EXPORT=1)
• add_definitions(-DHAVE_STRICMP=1)
• add_definitions(-DHAVE_WIN32_NATIVE_THREAD=1)
• add_definitions(-DUSE_WIN32_NATIVE_THREAD=1)
• add_definitions(-DENABLE_THREADS=1) +ENDIF()

include_directories(${CMAKE_CURRENT_SOURCE_DIR}) include_directories(${CMAKE_CURRENT_SOURCE_DIR}/mbfl) include_directories(${CMAKE_CURRENT_SOURCE_DIR}/nls) @@ -38,4 +45,4 @@ include_directories(${CMAKE_CURRENT_SOURCE_DIR}/filters)

add_subdirectory(nls) add_subdirectory(filters) -add_subdirectory(mbfl) \ No newline at end of file +add_subdirectory(mbfl) diff --git a/filters/CMakeLists.txt b/filters/CMakeLists.txt index 1353571..766103d 100644 --- a/filters/CMakeLists.txt +++ b/filters/CMakeLists.txt @@ -36,7 +36,10 @@ mbfilter_ucs2.c mbfilter_utf32.c mbfilter_utf16.c mbfilter_utf8.c mbfilter_utf7. mbfilter_utf7imap.c mbfilter_euc_jp_win.c mbfilter_cp932.c mbfilter_cp51932.c mbfilter_euc_cn.c mbfilter_euc_kr.c mbfilter_uhc.c mbfilter_iso2022_jp_ms.c mbfilter_iso2022_kr.c mbfilter_cp866.c mbfilter_koi8r.c mbfilter_koi8u.c -mbfilter_armscii8.c mbfilter_cp850.c html_entities.c) +mbfilter_armscii8.c mbfilter_cp850.c html_entities.c mbfilter_sjis_2004.c +mbfilter_sjis_mac.c mbfilter_euc_jp_2004.c mbfilter_sjis_mobile.c mbfilter_sjis_open.c +mbfilter_tl_jisx0201_jisx0208.c mbfilter_gb18030.c mbfilter_cp5022x.c mbfilter_iso2022jp_2004.c +mbfilter_iso2022jp_mobile.c mbfilter_utf8_mobile.c)

foreach(mbfl_filter_file ${_mbfl_filters_files})

list(APPEND mbfl_filters_files "${CMAKE_CURRENT_SOURCE_DIR}/${mbfl_filter_file}")

[ghost]

can you submit this as a proper pull request instead of attaching the patch here?

[sandeeptt]

Could you please let me know how to do it? When I clicked on 'Create pull request', I didn't understand how to attach the patch there Sandeep.

 On Monday, January 5, 2015 5:27 PM, Johnny Robeson <[email protected]> wrote:

can you submit this as a proper pull request instead of attaching the patch here?— Reply to this email directly or view it on GitHub.

[hirokawa]

To know about the proper pull request procedure, please look, https://help.github.com/articles/using-pull-requests/

[glensc]

you could at least wrap the code into block surrounted by three backticks:

```
patch content here
```