gruvbox
gruvbox copied to clipboard
Spelling: Switch capital/bad word colors
Closes #175
Ping, is there any way to get this merged? Do I need to do anything else?
Bumping this up again, is there anything I can do to get this merged? Thank you!
Checked this solution.
It works in combination with let g:gruvbox_guisp_fallback = "bg" (documentation update is welcome). And I didn't notice any unexpected artifacts. Would be glad to see it merged.
I've rebased and signed the commit, anything else that needs to be done?
@morhetz has not had the time and/or interest to maintain the project, so either more maintainers need to be added or a community fork has to be done.
@polyzen gruvbox is open source project I believe there are enough forks at the github and you're free to maintain your own As it's distributed under MIT license I feel like you have no restrictions to do so However gruvbox was started as a personal project and was maintained in my own tempo and according to my personal taste At the moment I think that adding maintainers is not what I would like to see No offence
@morhetz, I am definitely not meaning to offend either. Perhaps you would feel more comfortable if you moved the repo to a Gruvbox org before adding more maintainers. As you said, it was a personal project and was maintained, but after an open source project gets so popular, there is more concern to keep it sustained.
@fd0, deus is pretty nice, coming from Gruvbox, but unfortunately is only available in dark. I use Gruvbox's light variant while the Sun is still out.
What I was mainly interested in is a general yes/no answer. Not merging it is perfectly fine, although I must admit that despite me being an open source maintainer myself (see restic), not getting an answer for several years made me sad.
Thanks for the recommendations for other colorschemes, but I'll stick with my fork of gruvbox for now.
I'm very thankful that @morhetz spent time on gruvbox and made it available for all other people to use! Thank you, @morhetz! I know the other side, please continue working in your own pace when you feel like it, don't let anyone tell you what to do :)
@fd0 Thank you for the kind words. Not answering for several years makes me even more sad. Unfortunately sometimes things go weird and you have no time/passion to thank gruvbox community enough for all the support and maintain issues/prs with enough of attention. I'm definitely sorry about that. ❤️
Speaking of current PR, I'm pretty sure I'm going to merge it during this week. Just need to finally sort the issues out and review PRs.
It's been a couple months since the last update.
I've started a gruvbox community organization. I've copied all current gruvbox issues and pull requests there. I plan to do the same with gruvbox-contrib soon.
All of the pull requests have already been sorted through and merged if appropriate, including this one. I have started making patches for issues which will be submitted as pull requests here.
https://github.com/gruvbox-community/gruvbox/
I thought I would post about it here since there's a lot of talk in this thread about adding more maintainers and I hope this is a good alternative. My hope is to get more maintainers in the organization and make it community-driven and the definitive fork of gruvbox.
No insult is meant to @morhetz. Like others have said in this thread, I am extremely grateful for everything you've done. I've also been on the other side of this.
I hope that we can get more eyes on pull requests, more hands on changes sooner, and contribute a lot of pull requests for long-standing issues to gruvbox.