ComposeUI icon indicating copy to clipboard operation
ComposeUI copied to clipboard

fix(fdc3) - Refactored DesktopAgent queries to find the appropriate intents via raiseIntent, findIntent, findIntentsByContext call. Removed unnecessary codes, tests, code cleanup

Open lilla28 opened this issue 1 year ago • 1 comments

Changes:

  • refactored the intent queries (within backend's RaiseIntent, FindIntent, FindIntentsByContext handlers)
  • removed unnecessary code snippets and tests based on: https://github.com/morganstanley/ComposeUI/commit/57ad7daab2f8e28d63b335562b7f8b2bdf20fe79
  • fixed typos within classes, descriptions, test utils (sample appdirectory)
  • removed unnecessary property from RaiseIntentRequest classes. image

lilla28 avatar Apr 19 '24 15:04 lilla28

Codecov Report

Attention: Patch coverage is 79.25311% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 74.07%. Comparing base (43ac1b4) to head (eadcf64).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
- Coverage   74.34%   74.07%   -0.28%     
==========================================
  Files         241      241              
  Lines        7398     7482      +84     
  Branches      771      829      +58     
==========================================
+ Hits         5500     5542      +42     
- Misses       1706     1745      +39     
- Partials      192      195       +3     
Files Coverage Δ
...nt/src/DesktopAgent/Contracts/FindIntentRequest.cs 100.00% <ø> (ø)
...ktopAgent/Contracts/FindIntentsByContextRequest.cs 100.00% <ø> (ø)
...t/src/DesktopAgent/Contracts/RaiseIntentRequest.cs 100.00% <ø> (ø)
...e/Internal/Fdc3DesktopAgentMessageRouterService.cs 94.84% <100.00%> (+1.91%) :arrow_up:
...ucture/Internal/RaiseIntentResolutionInvocation.cs 100.00% <100.00%> (ø)
.../infrastructure/messages/Fdc3RaiseIntentRequest.ts 100.00% <100.00%> (ø)
...opAgent/src/DesktopAgent/Exceptions/ThrowHelper.cs 25.00% <0.00%> (+8.33%) :arrow_up:
...rastructure/Internal/RaisedIntentRequestHandler.cs 80.00% <63.63%> (-2.23%) :arrow_down:
.../DesktopAgent/src/DesktopAgent/Fdc3DesktopAgent.cs 78.64% <78.57%> (-6.43%) :arrow_down:

... and 1 file with indirect coverage changes

codecov[bot] avatar Apr 23 '24 10:04 codecov[bot]