ComposeUI icon indicating copy to clipboard operation
ComposeUI copied to clipboard

feat(fdc3) - Add leftover FDC3 native client implementation

Open lilla28 opened this issue 1 month ago • 1 comments

Implemented

  • GetUserChannels
  • FindIntent
  • GetOrCreateChannel
  • FindInstances
  • FindIntentsByContext
  • RaiseIntentForContext
  • RaiseIntent
  • AddIntentListener
  • Open
  • CreatePrivateChannel

lilla28 avatar Nov 03 '25 14:11 lilla28

Codecov Report

:x: Patch coverage is 66.92776% with 380 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.8%. Comparing base (b4cd6c6) to head (9e8e561).

Files with missing lines Patch % Lines
...Infrastructure/Internal/Protocol/PrivateChannel.cs 51.0% 89 Missing and 23 partials :warning:
...estHelpers/DesktopAgentClientConsoleApp/Program.cs 0.0% 77 Missing :warning:
...t.Client/Infrastructure/Internal/IntentListener.cs 65.3% 31 Missing and 12 partials :warning:
...pAgent.Client/Infrastructure/DesktopAgentClient.cs 63.3% 21 Missing and 12 partials :warning:
...rnal/PrivateChannelContextListenerEventListener.cs 29.0% 21 Missing and 1 partial :warning:
.../Internal/PrivateChannelDisconnectEventListener.cs 30.0% 20 Missing and 1 partial :warning:
...oseUI.Fdc3.DesktopAgent/Fdc3DesktopAgentService.cs 36.6% 16 Missing and 3 partials :warning:
....Client/Infrastructure/Internal/ContextListener.cs 37.9% 13 Missing and 5 partials :warning:
...nt.Client/Infrastructure/Internal/IntentsClient.cs 92.8% 5 Missing and 6 partials :warning:
...t.Client/Infrastructure/Internal/ChannelFactory.cs 93.3% 6 Missing and 3 partials :warning:
... and 6 more

:x: Your patch check has failed because the patch coverage (66.9%) is below the target coverage (100.0%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #1114     +/-   ##
=======================================
+ Coverage   64.3%   65.8%   +1.4%     
=======================================
  Files        325     334      +9     
  Lines       8681    9761   +1080     
  Branches    1103    1283    +180     
=======================================
+ Hits        5587    6426    +839     
- Misses      2781    2955    +174     
- Partials     313     380     +67     
Files with missing lines Coverage Δ
...DependencyInjection/ServiceCollectionExtensions.cs 100.0% <100.0%> (ø)
...t.Client/Infrastructure/Internal/MetadataClient.cs 94.8% <100.0%> (+1.9%) :arrow_up:
...Client/Infrastructure/Internal/Protocol/Channel.cs 96.0% <100.0%> (ø)
...ternal/Protocol/PrivateChannelInternalEventType.cs 100.0% <100.0%> (ø)
...topAgent.Shared/Converters/ContextJsonConverter.cs 100.0% <ø> (ø)
...pAgent.Shared/Converters/ValuationJsonConverter.cs 100.0% <100.0%> (ø)
....Fdc3.DesktopAgent.Shared/Fdc3StartupParameters.cs 100.0% <ø> (ø)
...dc3.DesktopAgent.Shared/SerializerOptionsHelper.cs 100.0% <100.0%> (ø)
...DependencyInjection/ServiceCollectionExtensions.cs 100.0% <100.0%> (ø)
....ComposeUI.Fdc3.DesktopAgent/Fdc3ShutdownAction.cs 68.0% <100.0%> (ø)
... and 20 more

... and 12 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 03 '25 17:11 codecov[bot]