Morgan Williams

I think the Middlemost/Le Maitre Fe correction should be able to be done in a vectorised way so will see if I can do that today also.

@bomtuckle no worries, I suspect it's similarly busy for everyone this time of year! I'll take a look at the Fe correction and if it fits perhaps ask you to...

@ChetanNathwani I've been able to verify a few things here, but like your original calculations I get a bit of a mess comparing Verma's results to mine on the output...

Hi @ChetanNathwani! There certainly might be a few errors in the mix, or just differences we don't know about. I can spend a bit more time looking at it, but...

Hey @ChetanNathwani, no worries, we're all a bit the same, and you've already put a lot of work into this one! I'll look to merge this across to `develop` after...

Hey @bomtuckle and @ChetanNathwani - just a heads up that I've merged the CIPW branch into develop. I won't have time to round this off this week (a few things...

Hey @bomtuckle, just a few quick questions about the new implementation: * Did you intend to have floor/integer division (e.g. `pt.formula("CaO").mass // 56.0774`) in the latter sections of the calculation...

Otherwise things are looking good. The only potential issues I spot with the test dataset at the moment is that there's a bit of a deviation for some compositions in...

Thanks! I'll do a bit more digging and see what I can figure out, I'll also add the free components to the return value somewhere. I'll look to see if...

In our test dataset, there's only a few analyses with F present - and I suspect each of the two groups of analyses have different units (one ppm, one wt%...