morenol

Results 69 comments of morenol

This should be fixed by https://github.com/infinyon/node-bindgen/pull/259 @RaphaelDarley Can you try again using the latest changes on this PR? In case that it fails, could you describe which node version you...

Thanks for the PR, let me know when it is ready to review

> Does this mean that `default_send_request_handler` basically previously didn't work by default? If so, that seems bad! > > Would you be up for adding a test for this? I...

Yes, I was just trying to make sure that this fails on main, but it looks like it is failing not in the expected way for me to fail.

I don't mind but I think that this test is not accurate, feel free to check and create a test that could reproduce the current issue

Closed since a similar test was added in #8671

Yes, I can do that, give me a couple of days to create a GitHub workflow to do that and ask for typesense members to take ownership of the crate...

@kishorenc @jasonbosco do you have a crates.io account? I would like to add you as owner of typesense crates so we can setup this repo with a workflow to release...