Frank icon indicating copy to clipboard operation
Frank copied to clipboard

Added `wait_for_nothing_visible_to_be_animating` for UIRefreshControl animation issue

Open samst0r opened this issue 10 years ago • 3 comments

Added wait_for_nothing_visible_to_be_animating helper method which checks for views that are animating and are also FEX_isVisible.

This resolves the issues with the UIRefreshControl (Issue #266).

samst0r avatar Mar 13 '14 18:03 samst0r

+1 to this.

seanoshea avatar Mar 14 '14 14:03 seanoshea

Thanks for the contribution. I'm not sure I like the approach of making two separate frankly_map calls and then zipping the two sets of views together. It assumes that the same set of views will come back, in the same order. That won't happen in all cases (e.g. while a screen transition is happening).

Could you approach this by adding an FEX_isAnimatingAndVisible method on the objective C side so that you could just do something like:

def wait_for_nothing_visible_to_be_animating( timeout = false )
    wait_until :timeout => timeout do
      !element_exists('view FEX_isAnimatingAndVisible')
    end
  end

moredip avatar Mar 18 '14 15:03 moredip

No worries. I'll go ahead and add that into ObjC side. That's a good shout.

samst0r avatar Mar 18 '14 17:03 samst0r