Alex Willmer

`mitogen.core.Broker` accepts a `poller_class` argument https://github.com/mitogen-hq/mitogen/blob/bb9c51b3e9cc39fceddd55578bb89680fa4e1acc/mitogen/core.py#L3580 but it ignores it https://github.com/mitogen-hq/mitogen/blob/bb9c51b3e9cc39fceddd55578bb89680fa4e1acc/mitogen/core.py#L3588 - [ ] Do any call sites use this? - [ ] Should it be fixed? - [ ]...

Compounds and compounded by #1058

At least one case in `mitogen.master`

This condition can never be true, and the reason string looks misleading. Probably a copy and paste error when it was introduced by https://github.com/mitogen-hq/mitogen/commit/501cfca82b50af3576390ca69ad436bbba74a483 https://github.com/mitogen-hq/mitogen/blob/21e874e60c5cc8fb8c6a0532a98fcc447c1ae2ab/tests/ansible/tests/affinity_test.py#L214-L227

Only testlib.py from the test suite makes it to PyPI ``` $ tar tf mitogen-0.3.5.tar.gz| grep test mitogen-0.3.5/tests/ mitogen-0.3.5/tests/testlib.py ``` this is contrary to what Django and ansible-core do. Fix...

From the docs > Returns the number of bytes sent. Applications are responsible for checking that all data has been sent; if only some of the data was transmitted, the...

Too many cases of bare `except:` and `except Exception:`

1

There are 40ish lines containing a bare `except:` or overly broad `except Exception`. They're probably hiding errors that we don't want to hide ``` ➜ mitogen git:(github-actions) ✗ ag "except:|except...

> I also failed at the first step of trying to look at adding tests as the instructions here https://github.com/mitogen-hq/mitogen/blob/master/tests/README.md#steps-to-prepare-development-environment reference some scripts that don't seem to exist any more....

Wild guess: Mitogen incorrectly rejects or is blind to the directory structure used by the system Python, e.g. `/usr/lib/python3.9/vendor-packages/ansible`. * Which version of Ansible are you running? 2.15.12 * Is...

Ansible 10 + mitogen_linear + reset_connection fails

1

`meta: reset_connection` fails in combination with `strategy: mitogen_linear` and `ansible_host_key_checking: true`. The same combination works with vanilla Ansible (`strategy: linear`) ```ini [targets] hkc-true ansible_host=localhost ansible_host_key_checking=true ``` ```yaml - hosts: targets...