Alex Willmer
Alex Willmer
Notes to myself - `ansible_mitogen.target.is_good_temp_dir(path)` has a misleading name. It doesn't _just_ do checks on an existing dir, it attempts to *create* the path.
Sorry for the long wait on this PR. I plan to look at it shortly. RIght now I'm using it as a guinea pig, to test the new Github Actions...
I'm attempting to reproduce this. Step 4 of https://github.com/markafarrell/mitogen-repro-issue-1061 doesn't leave a running container. Instead it immediately exits. ``` alex@ubuntu2004:~/mitogen-repro-issue-1061$ docker run -dt --name target-server \ -v /sys/fs/cgroup:/sys/fs/cgroup:ro \ --privileged...
``` alex@ubuntu2004:~/mitogen-repro-issue-1061$ docker rm target-server target-server alex@ubuntu2004:~/mitogen-repro-issue-1061$ docker run -dt --name target-server -v /sys/fs/cgroup:/sys/fs/cgroup:ro --privileged geerlingguy/docker-debian12-ansible:latest; dea854a953ce1386fcf0ca7b5a28065b5749c982dab711e98fb7210f5968ba39 ``` ``` alex@ubuntu2004:~/mitogen-repro-issue-1061$ docker logs target-server systemd 252.22-1~deb12u1 running in system mode (+PAM...
That did it, and I see the `_os.mkdir(file, 0o700)` error. Which leads to the next questions 1. Why don't the unit and integration tests see this? Which extra ingredient(s) matter...
There are unit tests that mention `is_good_temp()` in https://github.com/mitogen-hq/mitogen/blob/bb9c51b3e9cc39fceddd55578bb89680fa4e1acc/tests/ansible/tests/target_test.py#L31. Integration tests should probably be added amongst https://github.com/mitogen-hq/mitogen/blob/bb9c51b3e9cc39fceddd55578bb89680fa4e1acc/tests/ansible/integration/runner/all.yml. For running tests I'm relying on the Azure CI, and (force) pushing changes....
> 1. Why don't the unit and integration tests see this? Which extra ingredient(s) matter - Debian 12? systemd? Something Jeff Geerling added? A factor I previously missed: the repro...
Sorry for the wait. You need - [x] [Changelog](https://github.com/mitogen-hq/mitogen/blob/master/docs/changelog.rst) entry - [ ] Regression test in https://github.com/mitogen-hq/mitogen/tree/master/tests/ansible/regression Optional - Add yourself to https://github.com/mitogen-hq/mitogen/blob/master/docs/contributors.rst#productivity-lovers - `git rebase` down to a single...
I'll take a look, thanks On Tue, 28 Jan 2025 at 18:22, Alexander ***@***.***> wrote: > I am not sure why some of these tests are failing with su ......
After some investigation in #1233 I don't know why the su test is failing and I think I've found a second problem. So far FQCN su is not supply the...