styled-media-query icon indicating copy to clipboard operation
styled-media-query copied to clipboard

Write tests with jest (Coverage 100%)

Open timhagn opened this issue 5 years ago • 2 comments

As written in the now closed #15, I updated the tests in regard to the changes made to this repo in the meantime. As the default values for the internal functions pxToEmOrRem() and getSizeFromBreakpoint were never used, I removed them. Now the tests are at 100% and I only added packages as devDependencies : ).

Is this now mergeable ; )?

Best,

Tim.

=============================== Coverage summary ===============================
Statements   : 100%
Branches     : 100%
Functions    : 100%
Lines        : 100%
================================================================================

timhagn avatar Oct 25 '19 16:10 timhagn

Hola, is anybody out there % )?

timhagn avatar Nov 22 '19 19:11 timhagn

Hi there,

welcome to the collaborator club : ). Am in the suggestions - but keep in mind that I wrote this PR three quarts of a year ago ; ). Also, I'm quite booked at the moment, so don't know, when I will have time to change this.

Best,

Tim.

timhagn avatar Jul 07 '20 19:07 timhagn