styled-media-query icon indicating copy to clipboard operation
styled-media-query copied to clipboard

Published 20 hours ago • verified publisher icon morajabi

Add tests with Jest

Open morajabi opened this issue 7 years ago • 9 comments

morajabi avatar Jul 09 '17 12:07 morajabi

Maybe I can take this? @morajabi Why did you choose Jest?

brajabi avatar Jul 09 '17 17:07 brajabi

Great! I think Jest is simplest method with awesome features out-of-the-box! If you have any questions mention me.

morajabi avatar Jul 09 '17 18:07 morajabi

Hope, I haven't stepped on anyone's toes, but I just went ahead and started writing the tests. @morajabi Maybe you could merge my first PR ahead of them, so you could "test" if your build workflow with rollup is really still working with npm. Had to add react & react-dom (same versions as in styled-components, speaking newest 16.6.0) to devDependencies for the tests to run.

timhagn avatar Oct 26 '18 00:10 timhagn

@timhagn No, you haven't stepped on anyone's toes! 😄🙌

morajabi avatar Oct 26 '18 08:10 morajabi

@morajabi Puh, now I'm relieved ^^. Just thought, because @brajabi wanted to do this in July, there might be a conflict of interest ; ).

timhagn avatar Oct 26 '18 12:10 timhagn

Is this and my PR #15 stale or still welcome? Also, how shall it interact and be merged with #16 pertaining #3? Questions above questions ^^.

timhagn avatar Mar 06 '19 20:03 timhagn

@timhagn Surely welcome, why not? I'm not sure, should we merge #15 first or #16?

morajabi avatar Mar 07 '19 07:03 morajabi

Hi @morajabi,

though I'm quite new to TypeScript, I like the work @franky47 put into #16. But as was pointed out in the first comment of PR #16 maybe #15 should be merged first, methinks.

What do the others think?

(And I just asked if this issue / #15 were now stale, cause of the time lag ; ).

timhagn avatar Mar 08 '19 12:03 timhagn

Opened a new PR #19 with updated tests bringing them to 100% coverage : )

timhagn avatar Oct 25 '19 19:10 timhagn