simone icon indicating copy to clipboard operation
simone copied to clipboard

Theme Review

Open grappler opened this issue 11 years ago • 2 comments

As I was doing the PR https://github.com/mor10/simone/pull/41 I saw a few things that could be improved.

  • As the image size handles are not prefixed they could class with a plugin if it had the same handle. https://github.com/mor10/simone/blob/master/functions.php#L60-64
  • You should be using only one option in the database. The settings should be saved in a single array. So the setting would be simon_settings and everything would be saved in there. The problem is in line 35 of customizer.php It should be 'simon_settings[simone_header_color]'
  • The setting output should be escaped in simone_customizer_css().
  • There is no use for simon.mo. It can be deleted.

grappler avatar Dec 04 '14 23:12 grappler

Thanks for doing this @grappler. I'll flag these and get them sorted in the next update.

Just fyi on point 2: The first setting is old, the second is new. I added more features and started messing with the structure of the whole document and the result was I overlooked the old stuff.

mor10 avatar Dec 05 '14 20:12 mor10

Feature request: Ability to add a logo to the header.

stevengutierrez avatar Apr 22 '15 12:04 stevengutierrez