moqui-framework icon indicating copy to clipboard operation
moqui-framework copied to clipboard

Improve handling of service-special when incorrect parameters are given.

Open eigood opened this issue 1 year ago • 1 comments

When using service special, and parameters are given that do not pass validation, moqui will attempt to log this. However, doing so requires an active transaction. Service special runs this after the current transaction has completed, so the validate logic fails to run, and a NO_TRANSACTION message is printed instead, hiding the root cause of the error.

So, now we implicitly validate the service call in beforeCompletion(), so the current transaction will fail, and the root cause(incorrect parameter specification) can be shown.

eigood avatar May 08 '23 19:05 eigood