Borderlands-Commander icon indicating copy to clipboard operation
Borderlands-Commander copied to clipboard

Failed to import mod, returned null with no error

Open grzekozl opened this issue 2 years ago • 3 comments

Just installed (and reinstalled) commander, getting this error every time I boot up the game. image

grzekozl avatar Jun 28 '22 20:06 grzekozl

Commenting out lines 90, 91, 94, 95, and adding _NoDamageNumberEmitters = [None, None] allows the mod to run

grzekozl avatar Jun 28 '22 21:06 grzekozl

sane works for me thanks @grzekozl

Kallinteris-Andreas avatar Jul 11 '22 12:07 Kallinteris-Andreas

Unfortunately this is a larger issue with arrays in the SDK when running through Proton. Certain modifications to

Commenting out lines 90, 91, 94, 95, and adding _NoDamageNumberEmitters = [None, None] allows the mod to run

This clears the entire emitter array rather than just replacing the first two elements. While this will indeed work to remove damage numbers, it will also remove a number of other forms of feedback in the game (critical hit indicators and resist numbers, I believe). Try using this to construct NoDamageNumberEmitters instead:

NoDamageNumberEmitters = [emitter if index > 1 else None for index, emitter in enumerate(DamageNumberEmitters)]

If you can confirm this works in Proton, I'll switch to that method in a future version.

mopioid avatar Oct 22 '23 06:10 mopioid