keysnail icon indicating copy to clipboard operation
keysnail copied to clipboard

kkk: Fix broken ctrl-tab behavior

Open jgeerds opened this issue 8 years ago • 4 comments

The "switch window" functionality is broken on sites where KKK is enabled. The dialog pops up and multiple tab keypresses are also recognized but when you release the ctrl-tab keys, nothing happens. It appears that KKK is eating the "keyup" event.

This commit prevents KKK from hooking into events when ctrl-tab is pressed.

jgeerds avatar Aug 05 '16 10:08 jgeerds

This is strange. I use KKK too and Ctrl+TAB works fine on those KKK enabled sites.

caikechao avatar Aug 05 '16 11:08 caikechao

There are different behaviors for Ctrl-Tab. Did you turn on browser.ctrlTab.previews in about:config ?

Seems like KKK works fine with disabled ctrlTab.previews (even before my fix)

jgeerds avatar Aug 05 '16 12:08 jgeerds

:+1: @jgeerds browser.ctrlTab.previews is false (by default) in my about:config. Maybe it is this config that changes the behaviour of Ctrl-Tab.

caikechao avatar Aug 05 '16 13:08 caikechao

@kccai Try enabling browser.ctrlTab.preview and then use Ctrl-Tab on a site where KKK is enabled. Then you should see that the window switcher popup doesn't disappear.

If you want to test my fix there is a pretty simple way:

  1. open the kkk.ks.js from my commit
  2. right click on the raw button right above the file content and chose install this extension or something similar

Don't forget to restart Firefox after you installed the fixed version of KKK

btw. I'm running on Firefox 47.0.1

jgeerds avatar Aug 05 '16 13:08 jgeerds