js2-mode icon indicating copy to clipboard operation
js2-mode copied to clipboard

How to make `js2-error` font face underlined in my setup?

Open redguardtoo opened this issue 7 years ago • 8 comments

as title

redguardtoo avatar Mar 07 '18 05:03 redguardtoo

Try M-x customize-face.

dgutov avatar Mar 07 '18 10:03 dgutov

Doesn't work, here is the content of my custom-set-variables.el after turning on underlined attribute of js2-error font face:

(custom-set-faces
 ;; custom-set-faces was added by Custom.
 ;; If you edit it by hand, you could mess it up, so
 ;; Your init file should contain only one such insta
 ;; If there is more than one, they won't work right.
 '(js2-error ((t (:foreground "red" :underline nil))))

redguardtoo avatar Mar 07 '18 11:03 redguardtoo

It says :underline nil. Fix that!

dgutov avatar Mar 07 '18 11:03 dgutov

Still got the issue.

As you can see, console.log('hello') got js-warning face. It's correctly underlined. But qa1('hello') got js-error face but not underlined.

231235-07_1024x768

redguardtoo avatar Mar 07 '18 12:03 redguardtoo

It works for me.

dgutov avatar Mar 07 '18 12:03 dgutov

I use Emacs v25.2.2, js2-mode-20180301, on latest debian. I turn off the color theme but still got the problem.

redguardtoo avatar Mar 07 '18 12:03 redguardtoo

Have you restarted Emacs since changing the Custom file?

dgutov avatar Mar 07 '18 13:03 dgutov

Yes, I restarted Emacs several times. I also ran M-x describe-face js2-error and confirmed Underlined is red

Screen demo shot of console and GUI emacs:

redguardtoo avatar Mar 08 '18 09:03 redguardtoo