iso8583 icon indicating copy to clipboard operation
iso8583 copied to clipboard

Published 20 hours ago • verified publisher icon moov-io

feat: support EMV and TLV

Open mfdeveloper508 opened this issue 2 years ago • 1 comments

Created new 3 fields

  • EMV, ConstructedTLV, PrimitiveTLV Used existed pref and env
  • BerTLV, BerTLVTag

mfdeveloper508 avatar Jul 22 '22 15:07 mfdeveloper508

Codecov Report

Merging #187 (dc4801a) into master (151e28e) will decrease coverage by 4.81%. The diff coverage is 50.36%.

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   70.91%   66.09%   -4.82%     
==========================================
  Files          38       41       +3     
  Lines        1798     2348     +550     
==========================================
+ Hits         1275     1552     +277     
- Misses        336      530     +194     
- Partials      187      266      +79
Impacted Files Coverage Δ
field/spec.go 66.66% <ø> (ø)
field/constructed_tlv.go 45.26% <45.26%> (ø)
field/emv.go 47.73% <47.73%> (ø)
field/primitive_tlv.go 66.03% <66.03%> (ø)
prefix/bertlv.go 92.59% <100.00%> (+0.59%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 151e28e...dc4801a. Read the comment docs.

codecov-commenter avatar Jul 22 '22 15:07 codecov-commenter

Hey @adamdecaf and @alovak what should we do with this code?

wadearnold avatar Nov 03 '22 22:11 wadearnold

I'm not sure who has been able to test this code. If it's close to fully working I'm okay merging it.

Can we add a fuzz test or two? Doing so in a later PR would be fine with me.

adamdecaf avatar Nov 04 '22 15:11 adamdecaf

Personally, I have to read about EMV and see why we can't use the composite fields we already have. Currenly, we have a Message and CompositeField and they already duplicate a lot of code. In the PR I see we create one more "composite" field.

It would be great to get feedback from engineers that use our package and work with EMV if / what they need (I asked some people about it) and if the code in this PR helps them.

alovak avatar Nov 16 '22 15:11 alovak

EMV related ticket https://github.com/moov-io/iso8583/issues/200

alovak avatar Nov 16 '22 19:11 alovak

What's left on this before we could merge it?

adamdecaf avatar Dec 19 '22 14:12 adamdecaf

closing this in favor of #208. We can get back to this PR if we decide to use parts of it when we receive a feedback from users

alovak avatar Jan 11 '23 14:01 alovak