imagecashletter icon indicating copy to clipboard operation
imagecashletter copied to clipboard

file: a few fields are optional with vendors

Open adamdecaf opened this issue 4 years ago • 6 comments

What were you trying to do? A vendor has made additional fields nullable which our library doesn't handle. We should look into supporting these fields being null to properly parse their files.

  • checks:correctionIndicator should be nullable
  • bundleControl:creditTotalIndicator should be nullable
  • cashLetterControl:creditTotalIndicator should be nullable
  • fileControl:creditTotalIndicator should be nullable

What did you expect to see? File parsing should always work without errors on valid ICL files.

adamdecaf avatar Aug 03 '20 19:08 adamdecaf

@adamdecaf do you have a sample payload (or payloads) that hit these cases?

atonks2 avatar Nov 03 '20 22:11 atonks2

Not off hand. What I wrote before was handed to me over slack IIRC.

adamdecaf avatar Nov 04 '20 00:11 adamdecaf

Hi, are there any updates on this issue. I'm trying to parse a valid file that can be opened via X9 Reader software but I'm getting invalid file errors. For example in Return ICL files having a settlementDate in cashLetterControl is always blank and this field is conditional according to the docs. But the parser doesn't accept this as a valid ICL file. Is there any timeline for this feature to become available?

BTW, this is a great 3rd party lib! Thank you :)

SaraAdineh avatar Jun 12 '21 00:06 SaraAdineh

@SaraAdineh Thanks for the update. Do you have the spec version handy?

adamdecaf avatar Jun 16 '21 00:06 adamdecaf

@adamdecaf I'm not sure what the spec version is. What is that used for?

SaraAdineh avatar Jun 16 '21 16:06 SaraAdineh

@SaraAdineh There are multiple versions of ICL messages in the wild/production, so it's tricky to design a parser that supports all the options. If we're able to figure out what version you (or your vendor) requires it'll help us solve your issue.

adamdecaf avatar Jun 22 '21 20:06 adamdecaf