ach icon indicating copy to clipboard operation
ach copied to clipboard

Generate jni bindings

Open midepeter opened this issue 1 year ago • 2 comments

This PR is to realated to initial !1327 for generating java bindings for the ach library

midepeter avatar Feb 27 '24 13:02 midepeter

Can you include only the changes for JNI interop in this PR?

adamdecaf avatar Feb 27 '24 15:02 adamdecaf

Yes, that was what I intended to do ..

I think I had some commit issues … not sure why the commits mixed up but I fixed it up manually.

midepeter avatar Feb 27 '24 15:02 midepeter

@adamdecaf

could you help take a look at the update. Thank you

midepeter avatar Mar 05 '24 07:03 midepeter

@adamdecaf

Trust you are doing great.

Hopefully this passes the pending checks but i need a review from you on what i did to know if it fits for merging or if there is something more to do.

Thank you.

midepeter avatar Mar 15 '24 16:03 midepeter

@adamdecaf

The ubuntu build is failing due to the test coverage. I though since we were porting the library the unit testing was not compulsory. I am not sure what I should do in this case.

midepeter avatar Mar 25 '24 06:03 midepeter

@adamdecaf were these changes never merged in? i am just following up from our discussion. https://github.com/moov-io/ach/discussions/1373#discussioncomment-8619567

jason53 avatar Apr 11 '24 12:04 jason53

Correct they were not merged in. We still need to figure out a way to setup types/classes so the JNI layer supports them all.

I've tried another way but there are tons of unsupported classes, which is annoying. See https://github.com/moov-io/ach/pull/1406

adamdecaf avatar Apr 11 '24 18:04 adamdecaf