Jason K. Moore comments

Results 1408 comments of


                                            Jason K. Moore

Edit/config category for icons?

I support moving this to the other section too.

The "try jupyterlab" button on jupyter.org failed to create a binder

I don't know. I only tried it once.

Nosetests failures, mainly to do with Booleans and float64

Thanks. pandas has had a number of updates since the last release of this package. You can install an older version of pandas as a work around.

Nosetests failures, mainly to do with Booleans and float64

All these should be fixed in master. Can you confirm?

Loading a compensation trial doesn't really work

issue #77 may provide a solution avenue for this

Pandas is deprecating Panel

Panel was removed in Pandas 0.25.0, see https://pandas.pydata.org/pandas-docs/stable/whatsnew/v0.25.0.html

Realtime filter in leg2d seems to be rather slow

More on the scale of what we are doing. ``` octave:13> profile on octave:14> leg2d(rand(50000, 1), rand(50000, 12), rand(50000, 3), options); Marker 1: 0 samples are missing, longest gap is...

Realtime filter in leg2d seems to be rather slow

Octave 3.8 now has a JIT compiler that could speed up this filter loop. Another option would be to write the filter in C or something, as this is just...

Realtime filter in leg2d seems to be rather slow

We should probably replace the call to myfilfilt with http://octave.sourceforge.net/signal/function/filtfilt.html and then use finite differences for the differentiation. It would speed things up considerably.

Realtime filter in leg2d seems to be rather slow

Here is the output from some real data: ``` octave:8> profshow (data); # Function Attr Time (s) Calls ------------------------------------------------------------- 26 rtfilter 26.271 336056 25 myfiltfilt>rtfilter_batch 12.351 14 4 binary *...