Jason K. Moore
Jason K. Moore
> Do you know if it's possible to upload multiple wheels with one action? I guess we would need to revamp the CI if we wanted to build wheels for...
I'm -1 to these changes. If we want these functions to be used by typical users of the controls package, then functions should accept expressions. It is fine if Poly()...
> The problem of this approach is that the table will probably begin to generate very complicated expressions. This is prefered to it not working, not giving correct output, or...
I see that a number of tests/doctests have changed. This makes it unclear what the correct solutions are. You should be able to look through textbooks or work out problems...
Please provide more information in the first cell of the PR: References to other Issues or PRs Fixes https://github.com/sympy/sympy/issues/28010 Brief description of what is fixed or changed Other comments Release...
Once you update the top cell, I'll read your explanation of what this PR does. It isn't so clear to me.
Also, please open a new issue about the performance of the Routh table for large matrices or matrices with large expressions. This can be solved in a separate PR. This...
Using the example in #28010, I get: ``` In [2]: %time ss.get_asymptotic_stability_conditions() CPU times: user 2.6 s, sys: 24.6 ms, total: 2.63 s Wall time: 2.73 s ```
We discussed this in our meeting and agreed if a test for the negative real roots conditions function is added with the larger A matrix in #28010, then we can...
> Do I have to add the calculation here https://github.com/sympy/sympy_benchmarks/ ? No, just add a test here.