BicycleParameters icon indicating copy to clipboard operation
BicycleParameters copied to clipboard

Plotly is not in the requirements

Open tjstienstra opened this issue 1 year ago • 5 comments

When installing the development version of this repo, I noticed that plotly is currently not in the requirements, while it is being used.

tjstienstra avatar Apr 21 '23 16:04 tjstienstra

It is possible that one should also add pandas to the requirements. plotly seems to require it, but does not install it automatically?

I got the following error: ImportError: Plotly express requires pandas to be installed.

tjstienstra avatar Apr 21 '23 16:04 tjstienstra

pandas and plotly should be optional dependencies only needed for the app to run.

moorepants avatar Apr 21 '23 18:04 moorepants

import plotly.express as px is in main.py, so you kind of always need it now. It is used in _plot_bicycle_geometry_plotly and _plot_eigenvalues_vs_speed_plotly

tjstienstra avatar Apr 21 '23 18:04 tjstienstra

That needs to be moved out to another file.

moorepants avatar Apr 21 '23 18:04 moorepants

Fix proposed in #100.

moorepants avatar Apr 21 '23 18:04 moorepants