Model() should take a ParameterSet() instead of a dictionary as it's primary object

Open moorepants opened this issue 4 years ago • 1 comments

RIght now Model() takes a dictionary but that means you can't use any functionality of ParameterSet() inside of Model().

Oct 21 '21 16:10 moorepants

Actually it does! But the docstring is incorrect.

Oct 21 '21 16:10 moorepants

After using Model() for some time, none of the features of ParameterSet() are used in Model() so maybe it should only take a dictionary. Although, I guess if you had a parameter set for one model it could call the appropriate method to transform the data into the parameter set of a new model internally.

Oct 19 '22 05:10 moorepants

It takes a parameter set.

Oct 26 '22 09:10 moorepants